feat(s2n-quic-platform): make GSO/GRO configuration more ergonomic #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
camshaft
force-pushed
the
camshaft/gso-gro-config
branch
from
b48dabc to
c6fc937
Compare
WesleyRosenblum
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In #2078, it was suggested that the GSO/GRO configuration methods could be a bit nicer to use. This change adds new methods that take
bools which makes it easier to chain.I've updated the qns application to use the new methods.
Call-outs:
I think it's fine to keep the old methods. I debated marking them deprecated but I don't think it really hurts anything them being there indefinitely.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.